Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-34221 delete xtraceoptions response from tracestate only if present #121

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

tammy-baylis-swi
Copy link
Contributor

Delete xtraceoptions response from tracestate only if present. This is a bugfix to stop seeing this message that was logging at every single should_sample and inject call!:

The provided key xtrace_options_response doesn't exist.

tox tests pass on this PR. Exported test traces look ok on SWO and AO.

@tammy-baylis-swi tammy-baylis-swi requested a review from a team March 9, 2023 21:56
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tammy-baylis-swi!

@tammy-baylis-swi tammy-baylis-swi merged commit 69f75be into main Mar 9, 2023
@tammy-baylis-swi tammy-baylis-swi deleted the NH-34221-del-xto-response-only-if-present branch March 9, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants