Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-28860 liboboe 12 and manylinux_2_28 #107

Merged
merged 34 commits into from
Feb 3, 2023
Merged

Conversation

tammy-baylis-swi
Copy link
Contributor

Changes

  1. Bumps to liboboe 12.0.0
  2. Switches to manylinux_2_28_x86_64 for builds, because manylinux2014 is centos7-based.
  3. Drops centos7 support, because no longer supported by liboboe
  4. Drops Debian 9 support, because it's EOL and glibc version too old
  5. Drops Amazon Linux 2018.03 support, because glibc version too old
  6. Adds Alpine 3.12 install tests
  7. Adds Alpine 3.17 install tests
  8. Adds RHEL/UBI 8 install tests
  9. Fixes Ubuntu install test dependencies

Special Notes

  • Technically doesn't drop Ubuntu 16.04 support because it already wasn't being tested. 😁
  • Amazon Linux 2 cannot install solarwinds-apm from wheels because its glibc version (2.26) is older than manulinux_2_28 glibc version (2.28). It must install from sdist, like Alpine.
  • RHEL/UBI permissions are strict, so I added rw permissions to /workspace mount.
  • The RHEL/UBI 8 image for Python 3.8 is EOL in May 2023, so I'm only using the Python 3.9 image.
  • Alpine 3.12 testing does not include Python 3.10 because no stable image available.

Testing

Published to TestPyPI as 0.6.0.13: https://test.pypi.org/project/solarwinds-apm/0.6.0.13/.

Install-from-TestPyPI tests pass with these example traces exported:

SWO

AO

Please let me know if any questions/comments!

@tammy-baylis-swi tammy-baylis-swi marked this pull request as draft February 3, 2023 01:07
@tammy-baylis-swi
Copy link
Contributor Author

Draft until tox lint/format pass again.

@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review February 3, 2023 01:23
@tammy-baylis-swi tammy-baylis-swi requested review from cheempz and a team February 3, 2023 01:23
image: python:3.7-alpine3.12
options: --hostname py3.7-alpine3.12
steps:
- uses: actions/checkout@v2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth changing all the actions/checkout to v3 since v2 uses Node 12 which has been deprecated by GitHub

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!! Addressed in edbea14; much quieter test run completed here. 😄

@tammy-baylis-swi tammy-baylis-swi merged commit cbb913a into main Feb 3, 2023
@tammy-baylis-swi tammy-baylis-swi deleted the NH-28860-liboboe-12 branch February 3, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants