Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

[zk-token-sdk] Potential overflow when gens_capcity for the bulletproof generators become too large (ottersec #6) #33509

Closed
samkim-crypto opened this issue Oct 3, 2023 · 1 comment
Closed

[zk-token-sdk] Potential overflow when gens_capcity for the bulletproof generators become too large (ottersec #6) #33509

samkim-crypto opened this issue Oct 3, 2023 · 1 comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week.

Comments

@samkim-crypto
Copy link
Contributor

Problem

When gens_capacity becomes too large when generating BulletProofGens, then this could panic due to overflow.

Note: For token2022 application, we only use u64/u128/u256 batched range proofs, which can't panic, but it would be good to fix a potential panic in case range proof is used elsewhere more generally.

Proposed Solution

Introduce a maximum cap on gens_capacity.
@samkim-crypto samkim-crypto changed the title [zk-token-sdk] Potential overflow when gens_capcity for the bulletproof generators become too large [zk-token-sdk] Potential overflow when gens_capcity for the bulletproof generators become too large (ottersec #6) Oct 3, 2023
This was referenced Nov 17, 2023
Merged
Merged
@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 3, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
@joncinque
Copy link
Contributor

Fixed with #34065 and #34166

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joncinque @samkim-crypto