Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Feature Gate: Remove unnecessary check in loading of upgradeable program account #30559

Closed
pgarg66 opened this issue Feb 28, 2023 · 1 comment
Assignees
Labels
feature-gate Pull Request adds or modifies a runtime feature gate

Comments

@pgarg66
Copy link
Contributor

pgarg66 commented Feb 28, 2023

Description

The accounts.rs code currently checks if the message includes upgradeable loader key, if an upgradeable program is being loaded for writing. The check looks necessary and harmless at quick glance. But its unnecessary, as the transaction will fail due to other checks in the execution. The check is making it harder to refactor the code for the runtime V2/Cache replacement (#29803). This feature gate is needed to remove this check consistently across the network.

Feature ID

5ZCcFAzJ1zsFKe1KSZa9K92jhx7gkcKj97ci2DBo1vwj

Activation Method

Single Core Contributor

Minimum Beta Version

No response

Minimum Stable Version

No response

Testnet Activation Epoch

530

Devnet Activation Epoch

No response

Mainnet-Beta Activation Epoch

No response

@pgarg66 pgarg66 added the feature-gate Pull Request adds or modifies a runtime feature gate label Feb 28, 2023
@pgarg66 pgarg66 self-assigned this Feb 28, 2023
@Lichtso
Copy link
Contributor

Lichtso commented Jan 19, 2024

Cleaned up in #34840

@Lichtso Lichtso closed this as completed Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

No branches or pull requests

2 participants