Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

web3.js: Add transactionDetails config to getBlock #28999

Closed
steveluscher opened this issue Nov 30, 2022 · 1 comment · Fixed by #29000
Closed

web3.js: Add transactionDetails config to getBlock #28999

steveluscher opened this issue Nov 30, 2022 · 1 comment · Fixed by #29000
Labels
web3.js Related to the JavaScript client
Milestone
web3.js Roadmap –...

Comments

@steveluscher
Copy link
Contributor

Problem

This code throws:

await connection.getBlock(164000050, {
  maxSupportedTransactionVersion: 0,
  transactionDetails: 'none'
});

Proposed Solution

Implement the missing config.
@steveluscher steveluscher added the web3.js Related to the JavaScript client label Nov 30, 2022
@steveluscher steveluscher mentioned this issue Nov 30, 2022
Closed
This was referenced Nov 30, 2022
Merged
Merged
@ProfMoo
Copy link

ProfMoo commented Dec 2, 2022

@steveluscher Just pulled in the new version 1.68.0 and it works great :). Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
web3.js Related to the JavaScript client
Projects
None yet
Milestone
web3.js Roadmap – December 2022
Development

Successfully merging a pull request may close this issue.

feat: the web3.js getBlock APIs now accept rewards and transactionDetails config
2 participants
@steveluscher @ProfMoo