Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Webwallet transfer lamports instead of sols #2267

Closed
mvines opened this issue Dec 21, 2018 · 9 comments
Closed

Webwallet transfer lamports instead of sols #2267

mvines opened this issue Dec 21, 2018 · 9 comments
Assignees
Milestone

Comments

@mvines
Copy link
Contributor

mvines commented Dec 21, 2018

Depends-on: #160, specifically the SDK API changes to support this

@mvines mvines added this to the v0.12 Beacons milestone Dec 21, 2018
@garious garious changed the title Switch example webwallet to transfer sols instead of lamports Webwallet transfer lamports instead of sols Feb 2, 2019
@garious
Copy link
Contributor

garious commented Feb 14, 2019

@mvines, planning to squeeze this into Beacons?

@mvines
Copy link
Contributor Author

mvines commented Feb 14, 2019

Not in a big rush to do this, seems a little peripheral to the v0.12 release goals

@garious
Copy link
Contributor

garious commented Mar 21, 2019

On second thought, we might consider Sols being purely a solana-token. It could be special-cased to use its lamports instead of its account data to implement the ERC20 interface. @aeyakovenko?

@aeyakovenko
Copy link
Member

@garious, that is one of the biggest complaints about ethereum, that eth/wei are not native erc20’s.

@mvines
Copy link
Contributor Author

mvines commented Jul 10, 2019

I think the path to resolving this issue is to just have a switch in the example-webwallet that allows the user to work in lamports or SOLs (eg, Celsius or Fahrenheit). But along the way it would be nice to see some conversion helper functions added into https://github.com/solana-labs/solana-web3.js to avoid having to have the example-webwallet client write its own conversion logic.

@aeyakovenko
Copy link
Member

@mvines the bigger issue is similar to the problem that Ethereum has. Account's lamports are in the kernel. User defined Tokens are in userspace.

The wallet needs to be aware of the Account's lamports only when dealing with contract state management, but for general purpose tokens it should deal with the userspace representation of sols. We are lacking a general purpose token ABI to allow that.

@mvines
Copy link
Contributor Author

mvines commented Jul 10, 2019

Right. But that bigger issue is well outside the bounds of this particular issue.

So you suggest we just close this issue then?

@aeyakovenko
Copy link
Member

@mvines no, thats fine. WebWallet should display sols instead of lamports. kick the token can down the road :)

@jstarry
Copy link
Contributor

jstarry commented Aug 31, 2020

https://github.com/solana-labs/example-webwallet is archived now

@jstarry jstarry closed this as completed Aug 31, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants