Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Check file size of snapshot_version when unarchiving snapshot #18841

Closed
brooksprumo opened this issue Jul 22, 2021 · 1 comment · Fixed by #21925
Closed

Check file size of snapshot_version when unarchiving snapshot #18841

brooksprumo opened this issue Jul 22, 2021 · 1 comment · Fixed by #21925
Labels
good first issue Good for newcomers locked issue

Comments

@brooksprumo
Copy link
Contributor

brooksprumo commented Jul 22, 2021 •
edited
Loading

Related to #7167

Original comment from original PR:

also, I just noticed we're better off checking file size of snapshot_version? for eventual untrusted snapshot thing?

Otherwise, it could be dos vector if crafted snapshot contains a 100G zeroed snapshot_version file because we read all to memory first....

unrelated to this pr off course. so could be done as a follow up pr...

Originally posted by @ryoqun in #18504 (comment)
@brooksprumo brooksprumo added the good first issue Good for newcomers label Jul 22, 2021
@brooksprumo brooksprumo mentioned this issue Jul 22, 2021
Merged
4 tasks
@mooori mooori mentioned this issue Dec 15, 2021
Merged
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any activity in past 7 days after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers locked issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check file size of snapshot_version when unarchiving snapshot mooori/solana
1 participant
@brooksprumo