Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

bank.capitalization() can overflow #10916

Closed
rwalker-com opened this issue Jul 4, 2020 · 2 comments
Closed

bank.capitalization() can overflow #10916

rwalker-com opened this issue Jul 4, 2020 · 2 comments
Milestone

Comments

@rwalker-com
Copy link
Contributor

Problem

bank.capitalization is a u64, which could overflow at some point

Proposed Solution

promote to a u128 and deal with bank deserialization versioning

@mvines mvines added this to the v1.3.0 milestone Jul 4, 2020
@ryoqun
Copy link
Contributor

ryoqun commented Jul 6, 2020

Hehe, I and @svenski123 are working on this, this will be quite easy thing once all foundation (#10581) is merged like this: ryoqun@cd83759

@mvines mvines modified the milestones: v1.3.0, v1.3.4 Aug 15, 2020
@joncinque joncinque modified the milestones: v1.3.4, v1.3.6 Aug 28, 2020
@oJshua oJshua modified the milestones: v1.3.8, v1.3.9 Sep 3, 2020
@mvines mvines modified the milestones: v1.3.9, v1.3.10 Sep 9, 2020
@ryoqun
Copy link
Contributor

ryoqun commented Sep 15, 2020

I think this issue can be closed by #11927 because we're checking bank.capitalization are under u64::MAX periodically now.

Let's revisit this in distant future. :)

@ryoqun ryoqun closed this as completed Sep 15, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants