Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

IsCurrentConnectionStillActive() incorrectly returns true #3602

Closed
enjojoy opened this issue Nov 19, 2024 · 2 comments
Closed

IsCurrentConnectionStillActive() incorrectly returns true #3602

enjojoy opened this issue Nov 19, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@enjojoy
Copy link

enjojoy commented Nov 19, 2024

Overview

Issue is described in detail here trezor/trezor-suite#12628

Especially this comment trezor/trezor-suite#12628 (comment)

Please implement this todo as soon as possible

// TODO: Maybe add an 'errored' state or a retry limit?

@enjojoy enjojoy added the bug Something isn't working label Nov 19, 2024
@steveluscher
Copy link
Contributor

We won't be making this change, for a host of reasons. The major one is that a retry limit would forever halt reconnection attempts in such a way that your application would never learn about, because there is no way to throw errors back up to the subscription callsite. This subscriptions API is terminally flawed in this way, and we've completely rewritten it in @solana/web3.js version 2.0.

I'd be happy to send you a pull request to update your app to the new library.

trezor/trezor-suite#12628 (comment)

@steveluscher steveluscher closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2024
Copy link
Contributor

Because there has been no activity on this issue for 7 days since it was closed, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants