Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

multiple package manager lockfiles in web3.js #1108

Assignees

Comments

@wentokay
Copy link
Contributor

Problem

There's a yarn.lock and a package-lock.json in web3.js

Proposed Solution

Pick one package manager for the project and remove the lockfile that's associated with the other one

@jstarry
Copy link
Contributor

jstarry commented May 12, 2022

Yeah, @steveluscher why do we need both?

@steveluscher
Copy link
Contributor

Yeah! I noticed that. I'm not sure when the npm one snuck in, but it should begone.

@jstarry
Copy link
Contributor

jstarry commented May 12, 2022

package-lock.json was always in there, I noticed you added the additional yarn.lock file. I prefer npm personally, any reason you use yarn?

@steveluscher
Copy link
Contributor

npm has gotten a lot better, but I still carry damage from the days that made the creation of yarn necessary.

@steveluscher
Copy link
Contributor

Oops. Our build cache still relies on package-lock.json so it wasn't as simple as deleting it. I'll have to revisit this in a hot moment after I revert the deletion.

@steveluscher
Copy link
Contributor

2da8c8f

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Because there has been no activity on this issue for 7 days since it was closed, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.