Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with scarb for declare #2138

Merged
merged 39 commits into from
Jul 3, 2023
Merged

Build with scarb for declare #2138

merged 39 commits into from
Jul 3, 2023

Conversation

karol-bisztyga
Copy link
Collaborator

@karol-bisztyga karol-bisztyga commented Jun 27, 2023 •
edited
Loading

No description provided.

@karol-bisztyga karol-bisztyga linked an issue Jun 27, 2023 that may be closed by this pull request
Scarb integration with protostar-cli #2052
Closed
@karol-bisztyga karol-bisztyga marked this pull request as ready for review June 28, 2023 08:40
@karol-bisztyga karol-bisztyga requested a review from a team as a code owner June 28, 2023 08:40
@THenry14
Copy link
Member

let's target this branch to master.
Changes not related to interface change from inprove-cli-args can be moved in here.

THenry14
THenry14 reviewed Jun 28, 2023
View reviewed changes
cast/src/main.rs Outdated Show resolved Hide resolved
cast/src/main.rs Outdated Show resolved Hide resolved
cast/src/starknet_commands/declare.rs Outdated Show resolved Hide resolved
cast/src/starknet_commands/declare.rs Outdated Show resolved Hide resolved
cast/src/starknet_commands/declare.rs Outdated Show resolved Hide resolved
cast/src/starknet_commands/declare.rs Outdated Show resolved Hide resolved
cast/tests/declare_test/Scarb.toml Outdated Show resolved Hide resolved
maciektr
maciektr reviewed Jun 29, 2023
View reviewed changes
cast/src/starknet_commands/declare.rs Outdated Show resolved Hide resolved
cast/src/starknet_commands/declare.rs Outdated Show resolved Hide resolved
maciektr
maciektr reviewed Jun 29, 2023
View reviewed changes
cast/src/main.rs Show resolved Hide resolved
cast/src/starknet_commands/declare.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/M and removed size/L labels Jun 29, 2023
THenry14
THenry14 reviewed Jun 29, 2023
View reviewed changes
cast/src/starknet_commands/helpers.rs Outdated Show resolved Hide resolved
cast/src/main.rs Outdated Show resolved Hide resolved
@karol-bisztyga karol-bisztyga mentioned this pull request Jun 30, 2023
Closed
THenry14
THenry14 reviewed Jun 30, 2023
View reviewed changes
Copy link
Member

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, last few things to resolve and we're cooking 🔥

cast/src/main.rs Outdated Show resolved Hide resolved
cast/src/main.rs Outdated Show resolved Hide resolved
cast/src/main.rs Show resolved Hide resolved
war-in
war-in reviewed Jun 30, 2023
View reviewed changes
cast/src/starknet_commands/call.rs Outdated Show resolved Hide resolved
cast/src/starknet_commands/declare.rs Show resolved Hide resolved
piotmag769
piotmag769 approved these changes Jun 30, 2023
View reviewed changes
cast/src/main.rs Show resolved Hide resolved
THenry14
THenry14 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job mate 🔥

@karol-bisztyga karol-bisztyga added this pull request to the merge queue Jul 3, 2023
Merged via the queue into master with commit abce309 Jul 3, 2023
2 checks passed
@karol-bisztyga karol-bisztyga deleted the kb/cli-build-with-scarb branch July 3, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotmag769 piotmag769 piotmag769 approved these changes

@THenry14 THenry14 THenry14 approved these changes

@war-in war-in war-in approved these changes

@maciektr maciektr Awaiting requested review from maciektr

Assignees

@karol-bisztyga karol-bisztyga

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scarb integration with protostar-cli
5 participants
@karol-bisztyga @THenry14 @maciektr @piotmag769 @war-in