Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier #509

Merged
merged 6 commits into from
Dec 16, 2020
Merged

Prettier #509

merged 6 commits into from
Dec 16, 2020

Conversation

waterweasel4
Copy link
Contributor

Pull Request

Thank you for your contribution to the Bulwark. Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # 508

Type of change

  • A new feature
  • A bug fix
  • Documentation only changes
  • Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • A code change that neither fixes a bug nor adds a feature
  • A code change that improves performance
  • Adding missing tests or correcting existing tests
  • Changes that affect the build system or external dependencies
  • Changes to our CI configuration files and scripts
  • Other changes that don't modify src or test files

Add description here

Added prettier to the commits so that code is consistent and, well, prettier.

Checklist

  • My code follows the contributing guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Adding prettier so changes are consistent across developers and easier to read

fix #508
@waterweasel4 waterweasel4 changed the base branch from master to develop December 15, 2020 18:55
alejandrosaenz117 and others added 3 commits December 15, 2020 16:20
Updated prettier config.  Renamed file.  Added tslint support.  Temporarily removed pre-commit

feat #509
Minor changes to testing.md file for installing prettier, how it works

fix #509
TESTING.md Outdated Show resolved Hide resolved
TESTING.md Outdated Show resolved Hide resolved
TESTING.md Outdated Show resolved Hide resolved
waterweasel4 and others added 2 commits December 16, 2020 10:56
updating documentation for prettier

fix #509
Updated the prettier documentation in the TESTING.md file

doc #509
@alejandrosaenz117 alejandrosaenz117 linked an issue Dec 16, 2020 that may be closed by this pull request
@alejandrosaenz117 alejandrosaenz117 merged commit 53a3d5a into develop Dec 16, 2020
@waterweasel4 waterweasel4 deleted the prettier branch January 11, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettier R&D
2 participants