Assertions need to account for type of Symbol

[notmessenger]

tests/unit/helpers/sl/synchronous/contains-test.js

• "First non-optional argument must be an array, string or object"
• "Second non-optional argument must be an array, string or object"

[notmessenger]

emberjs/ember.js#11673 is not going to be resolved at this time so calls to Ember.typeOf() that are compared to 'object' must also contain logic similar to && 'symbol' != typeof

[notmessenger]

Will need to use jshint ignore entries like in https://github.com/softlayer/sl-ember-components/blob/688911c66d7a678fab6ff935b332d76593b5b400/addon/components/sl-chart.js#L95

[erangeles]

@notmessenger taking this.

[erangeles]

Update: Apparently symbol testing is on hold. adding label backlog to this.

[notmessenger]

The test-support/helpers/sl/synchronous/contains.js file can be modified for now though so that the logic is correct. You are correct that the test cannot be written yet though.

[erangeles]

@notmessenger I believe ac08ca8 addresses it, for accounting for symbol?

[notmessenger]

@erangeles Agreed.