Skip to content
This repository has been archived by the owner on Aug 24, 2019. It is now read-only.

initWithScrollView:delegate: should call initWithFrame: on super, not self #60

Closed
vadim-fueled opened this issue Jun 4, 2015 · 2 comments

Comments

@vadim-fueled
Copy link

Since initWithScrollView:delegate: is a de-facto designated initializer it should call designated initializer of superclass with super, not self
Explicitly stating that it's a designated initializer with NS_DESIGNATED_INITIALIZER would be nice.

@soffes soffes closed this as completed in 3ee6473 Jun 4, 2015
@vadim-fueled
Copy link
Author

Did this not result in a warning at https://github.com/soffes/sspulltorefresh/blob/3ee6473e1f35c8c1eab8c28c933592141a8a9759/SSPullToRefresh/SSPullToRefreshView.m#L161
which is my original complaint?
The thing is I can't subclass SSPullToRefreshView in Swift without overriding init(frame:) which is odd.

@soffes
Copy link
Owner

soffes commented Jun 4, 2015

Fixed that in 68ac0ee

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants