Skip to content

Commit 2ff36b1

Browse files
committed
Fix session creation.
1 parent 828bce0 commit 2ff36b1

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

lib/async/webdriver/bridge/pool.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,11 @@ def concurrency
7171
def acquire
7272
if @sessions.empty?
7373
session = @client.post("session", {capabilities: @capabilities})
74+
75+
if session.nil?
76+
raise Async::WebDriver::Error, "Failed to create session with capabilities: #{@capabilities.inspect}"
77+
end
78+
7479
session[:cache] = self
7580
session[:endpoint] = @driver.endpoint
7681

lib/async/webdriver/request_helper.rb

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,10 @@ def request_path(path = nil)
4646
# @returns [Object] The unwrapped value.
4747
def unwrap_object(value)
4848
if value.is_a?(Hash) and value.key?(ELEMENT_KEY)
49-
Element.new(self.session, value[ELEMENT_KEY])
50-
else
51-
value
49+
value = Element.new(self.session, value[ELEMENT_KEY])
5250
end
51+
52+
return value
5353
end
5454

5555
# Used by `JSON.load` to unwrap objects.
@@ -60,6 +60,8 @@ def unwrap_objects(value)
6060
when Array
6161
value.map!(&method(:unwrap_object))
6262
end
63+
64+
return value
6365
end
6466

6567
# Extract the value from the reply.

0 commit comments

Comments
 (0)