Skip to content

Commit 43c1c1c

Browse files
refactor: simplify code
1 parent 3b5e79e commit 43c1c1c

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

lib/server.ts

-11
Original file line numberDiff line numberDiff line change
@@ -464,12 +464,6 @@ export abstract class BaseServer extends EventEmitter {
464464
} else if ("websocket" === transportName) {
465465
transport.perMessageDeflate = this.opts.perMessageDeflate;
466466
}
467-
468-
if (req._query && req._query.b64) {
469-
transport.supportsBinary = false;
470-
} else {
471-
transport.supportsBinary = true;
472-
}
473467
} catch (e) {
474468
debug('error handshaking to transport "%s"', transportName);
475469
this.emit("connection_error", {
@@ -862,11 +856,6 @@ export class Server extends BaseServer {
862856
websocket.removeListener("error", onUpgradeError);
863857

864858
const transport = this.createTransport(req._query.transport, req);
865-
if (req._query && req._query.b64) {
866-
transport.supportsBinary = false;
867-
} else {
868-
transport.supportsBinary = true;
869-
}
870859
transport.perMessageDeflate = this.opts.perMessageDeflate;
871860
client.maybeUpgrade(transport);
872861
}

lib/transport.ts

+1
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ export abstract class Transport extends EventEmitter {
5252
this.discarded = false;
5353
this.protocol = req._query.EIO === "4" ? 4 : 3; // 3rd revision by default
5454
this.parser = this.protocol === 4 ? parser_v4 : parser_v3;
55+
this.supportsBinary = !(req._query && req._query.b64);
5556
}
5657

5758
/**

0 commit comments

Comments
 (0)