Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website Feature]: Migrate book page #558

Closed
2 tasks done
ssandino opened this issue Sep 1, 2023 · 3 comments · Fixed by #591
Closed
2 tasks done

[Website Feature]: Migrate book page #558

ssandino opened this issue Sep 1, 2023 · 3 comments · Fixed by #591
Assignees
Labels
feature New feature or request website Issues concerning Website

Comments

@ssandino
Copy link
Member

ssandino commented Sep 1, 2023

Is there an existing request for this feature?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

We should migrate the existing webpage Books (https://socialincome.org/books) to the new website setup. The URL should stay the same .../books and content as well.

It is an English only page. No translation files in German or Italian exist.

Describe the solution/feature

  • Add new webpage (website/src/app/[lang]/[country]/(website)/books)
  • Add text content to EN translation files (locales in shared)
  • Add the images (same level as page.tsx file for book page)

Describe alternatives you've considered

No response

Criteria for Completion

No response

Anything else?

  • Ignore header and footer
  • Hero background should be plain color bg-blue-50 instead of this design (with grey lines, see below)
Screenshot 2023-09-01 at 15 53 26

Code of Conduct

  • I've read the Code of Conduct and understand my responsibilities as a member of the Social Income community
@ssandino ssandino added feature New feature or request website Issues concerning Website labels Sep 1, 2023
@ssandino ssandino assigned ssandino and DarkMenacer and unassigned ssandino Sep 1, 2023
@DarkMenacer
Copy link
Contributor

Created branch 'pranav/migrate-books-page', link
After starting the server, the changes can be located at http://localhost:3001/en/us/books

@DarkMenacer
Copy link
Contributor

Currently, the bg color of section-1 is left white because changing it to bg-blue-50 is not producing the desired result due to margins present on the sides of the page

@mkue mkue linked a pull request Oct 20, 2023 that will close this issue
@DarkMenacer
Copy link
Contributor

PR created #591

@mkue mkue linked a pull request Oct 23, 2023 that will close this issue
@mkue mkue closed this as completed in #591 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request website Issues concerning Website
Projects
None yet
2 participants