From 44ff5f2b46a739e5ecca02f02461abeed19d8c4c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Szczerbi=C5=84ski?= Date: Thu, 19 Sep 2024 14:14:59 +0200 Subject: [PATCH 1/4] Disable all converter tests --- .../snowflake/client/core/arrow/BaseConverterTest.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/test/java/net/snowflake/client/core/arrow/BaseConverterTest.java b/src/test/java/net/snowflake/client/core/arrow/BaseConverterTest.java index 20a07a655..be1197e82 100644 --- a/src/test/java/net/snowflake/client/core/arrow/BaseConverterTest.java +++ b/src/test/java/net/snowflake/client/core/arrow/BaseConverterTest.java @@ -3,6 +3,7 @@ */ package net.snowflake.client.core.arrow; +import java.nio.ByteOrder; import java.util.TimeZone; import net.snowflake.client.core.DataConversionContext; import net.snowflake.client.core.SFSession; @@ -10,6 +11,8 @@ import net.snowflake.common.core.SFBinaryFormat; import net.snowflake.common.core.SnowflakeDateTimeFormat; import org.junit.After; +import org.junit.Assume; +import org.junit.Before; public class BaseConverterTest implements DataConversionContext { private SnowflakeDateTimeFormat dateTimeFormat = @@ -32,6 +35,11 @@ public void clearTimeZone() { System.clearProperty("user.timezone"); } + @Before + public void assumeLittleEndian() { + Assume.assumeTrue("Arrow doesn't support cross endianness", ByteOrder.nativeOrder().equals(ByteOrder.LITTLE_ENDIAN)); + } + @Override public SnowflakeDateTimeFormat getTimestampLTZFormatter() { return timestampLTZFormat; From 6b20da788cf43c122f1156c3e0c7cbbb57b8ae74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Szczerbi=C5=84ski?= Date: Mon, 23 Sep 2024 12:49:46 +0200 Subject: [PATCH 2/4] Add AIX Unit tests to Jenkinsfile --- Jenkinsfile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Jenkinsfile b/Jenkinsfile index 8e5925b8c..0b62008a0 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -87,6 +87,8 @@ timestamps { }.collectEntries { jobDefinition -> return [(jobDefinition.runName): { build job: jobDefinition.jobToRun, parameters: jobDefinition.params }] } + + jobDefinitions.put('JDBC-AIX-Unit', { build job: 'JDBC-AIX-UnitTests', parameters: { BRANCH: scmInfo.GIT_BRANCH } } ) stage('Test') { parallel (jobDefinitions) } From bedf2ce299547fbc15f4510e6fe9abab3a936e7b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Szczerbi=C5=84ski?= Date: Mon, 23 Sep 2024 12:56:37 +0200 Subject: [PATCH 3/4] Fix parameter passing --- Jenkinsfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Jenkinsfile b/Jenkinsfile index 0b62008a0..261a2968b 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -88,7 +88,7 @@ timestamps { return [(jobDefinition.runName): { build job: jobDefinition.jobToRun, parameters: jobDefinition.params }] } - jobDefinitions.put('JDBC-AIX-Unit', { build job: 'JDBC-AIX-UnitTests', parameters: { BRANCH: scmInfo.GIT_BRANCH } } ) + jobDefinitions.put('JDBC-AIX-Unit', { build job: 'JDBC-AIX-UnitTests', parameters: [ string(name: 'BRANCH', value: scmInfo.GIT_BRANCH ) ] } ) stage('Test') { parallel (jobDefinitions) } From 35f39e6ad0a54b485d3a536e9ebba94b924c1585 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Szczerbi=C5=84ski?= Date: Mon, 23 Sep 2024 14:00:32 +0200 Subject: [PATCH 4/4] Fix formatting --- .../net/snowflake/client/core/arrow/BaseConverterTest.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/test/java/net/snowflake/client/core/arrow/BaseConverterTest.java b/src/test/java/net/snowflake/client/core/arrow/BaseConverterTest.java index be1197e82..e669ac006 100644 --- a/src/test/java/net/snowflake/client/core/arrow/BaseConverterTest.java +++ b/src/test/java/net/snowflake/client/core/arrow/BaseConverterTest.java @@ -37,7 +37,9 @@ public void clearTimeZone() { @Before public void assumeLittleEndian() { - Assume.assumeTrue("Arrow doesn't support cross endianness", ByteOrder.nativeOrder().equals(ByteOrder.LITTLE_ENDIAN)); + Assume.assumeTrue( + "Arrow doesn't support cross endianness", + ByteOrder.nativeOrder().equals(ByteOrder.LITTLE_ENDIAN)); } @Override