SNOW-988793 Do not read arrow chunk when it is empty for arrow batches #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pfus
force-pushed
the
SNOW-988793-no-rows-arrow-batches
branch
2 times, most recently
from
b90df21 to
c248b31
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #998 +/- ##
=======================================
Coverage 82.83% 82.83%
=======================================
Files 50 50
Lines 9698 9701 +3
=======================================
+ Hits 8033 8036 +3
Misses 1665 1665 ☔ View full report in Codecov by Sentry. |
sfc-gh-pfus
force-pushed
the
SNOW-988793-no-rows-arrow-batches
branch
from
c248b31 to
6c68996
Compare
sfc-gh-pfus
force-pushed
the
SNOW-988793-no-rows-arrow-batches
branch
from
6c68996 to
6547127
Compare
sfc-gh-dheyman
approved these changes
Dec 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SNOW-988793 When arrow batches mode is used and the query returns no rows - we shouldn't create arrow reader at all.
Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them