Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-976500 Do not drop errors from chunk downloader starting #994

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-976500-stream-downloader-start branch from b6531df to eb79d02 Compare December 7, 2023 12:16
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e49463c) 82.83% compared to head (9c3b13b) 82.77%.
Report is 1 commits behind head on master.

Files Patch % Lines
async.go 16.66% 5 Missing ⚠️
rows.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
- Coverage   82.83%   82.77%   -0.06%     
==========================================
  Files          50       50              
  Lines        9698     9708      +10     
==========================================
+ Hits         8033     8036       +3     
- Misses       1665     1672       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-976500-stream-downloader-start branch from eb79d02 to 12809f3 Compare December 7, 2023 12:57
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review December 7, 2023 12:57
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner December 7, 2023 12:57
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-976500-stream-downloader-start branch from 12809f3 to 6fb46fc Compare December 18, 2023 12:59
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-976500-stream-downloader-start branch from 6fb46fc to 9c3b13b Compare December 19, 2023 06:26
@sfc-gh-pfus sfc-gh-pfus merged commit 4b69339 into master Dec 19, 2023
21 of 23 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-976500-stream-downloader-start branch December 19, 2023 09:35
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants