fix: improve existing icon matching with regex

remedyred · Jun 4, 2022 · 091590d · 091590d
1 parent 1336acc
commit 091590d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -41,6 +41,8 @@
 		"watch": "concurrently -n lib,cli \"pnpm run watch:lib\" \"pnpm run watch:cli\"",
 		"watch:cli": "pnpm run dev:cli --watch",
 		"watch:lib": "pnpm run dev:lib --watch"
+		"watch:lib": "pnpm run dev:lib --watch",
+		"schema": "pnpx get-graphql-schema https://api.fontawesome.com > schema.graphql"
 	},
 	"jest": {
 		"preset": "ts-jest",

diff --git a/src/actions/add.ts b/src/actions/add.ts
@@ -24,8 +24,9 @@ export default async argv => cli(argv)
 		for (let item of args.icons) {
 			let [icon, ...aliases] = item.split(',')
 
-			let iconName = normalizeIconName(icon.replace(/(fa[a-z]?)-/, `$1:`))
-			if (!config.icons.includes(iconName)) {
+			let iconName = cleanIconName(icon)
+			const reg = new RegExp(`^fa[a-z]?:(${iconName})$`)
+			if (!config.icons.find(i => reg.test(i))) {
 				const iconQuery = gql`
 				query ($query: String) {
 					search(version: "6.1.1", query: $query, first: 15) {id}