Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Use our own API client ID #164

Closed
Flynn95 opened this issue Dec 18, 2018 · 10 comments
Closed

Feature request: Use our own API client ID #164

Flynn95 opened this issue Dec 18, 2018 · 10 comments

Comments

@Flynn95
Copy link

Flynn95 commented Dec 18, 2018

💡 Feature request

What do you propose

Since SoundCloud limit API calls to 15000 per day, how about letting the user set his own client ID to continue using the app after it hit the limit?

Whats steps can we take to implement it

We can use an JSON external file in user's home folder, the app check for the file's existence and get the necessary data.
I haven't read the source code so I'll come back to this later.

Examples

The Soundnode app (https://github.com/Soundnode/soundnode-app) has implemented this, though incomplete but it works.

@sneljo1
Copy link
Owner

sneljo1 commented Dec 18, 2018

Yeah, that's possible. Luckily we haven't hit the limit just yet.

I was thinking perhaps we could write a chrome extension to intercept the client_id, pretty sure this is possible (https://medium.com/@gilfink/adding-web-interception-abilities-to-your-chrome-extension-fb42366df425).

if we can do this, we can handle this in a very clean way.

  • User installs extension =>
    • User presses login on Auryo =>
      • Browserwindow opens with SoundCloud =>
        • (User logs in) the extension fetches the clientId and sends it to the app via sockets just like the normal auth process

@N33G
Copy link

N33G commented Dec 20, 2018

Quick question on the subject if this gets implemented what does it mean to the limit on third party apps access will it let stream all tracks, or i am totally missing the point. Thanks in advance.

@sneljo1
Copy link
Owner

sneljo1 commented Dec 20, 2018

@N33G Limit will be gone and you'll see more tracks I think. But it's technically against SoundCloud TOS.

@N33G
Copy link

N33G commented Dec 20, 2018

I will keep an eye on the subject. This in one of the reasons keeping me from using Auryo full time.

@sneljo1
Copy link
Owner

sneljo1 commented Dec 20, 2018

@N33G Which one? not having all tracks available? Or the limit?

@N33G
Copy link

N33G commented Dec 20, 2018

The limit haven't been a problem really. Is just some tracks on playlists don't match with the web version or don't follow the sort order.

@chrismessina
Copy link

Luckily we haven't hit the limit just yet.

If this continues to be true, then I suppose this issue should remain low priority. If it becomes more of an issue, I still don't see a problem with having users register their own SoundCloud API client and simply entering their client and secret into an Advanced panel in Preferences. Yes, it would be an advanced feature, but would address the limitation effectively.

Spotificious for Alfred requires users to get a Spotify app client ID and secret in order to perform client-side searching of the user's Spotify account, and it isn't that difficult.

@sneljo1
Copy link
Owner

sneljo1 commented Feb 12, 2019

@chrismessina Yes indeed. My reason for the hacky workaround idea using the chrome extension is that there are only so many people who already have a SoundCloud client & secret. SoundCloud stopped issues new ones last year I believe.

@chrismessina
Copy link

Wow, didn't realize they stopped issuing new client IDs. Lame!

@Karrq
Copy link

Karrq commented Mar 8, 2019

SoundCloud client & secret

So I'd also need a secret key?
Does that mean SoundNode's ability to add your own clientId isn't sufficient anymore?

I'm asking because I tried SoundNode first since I had already heard of it. Then I tried yours and I personally enjoy it more (great work, seriously!). I went looking for a clientId thing but couldn't find it so I wanted to see if I could contribute and add this functionality, but if we also need a "secret" then I need to know what's that first!

@sneljo1 sneljo1 added this to the v2.4.0 milestone Mar 11, 2019
@sneljo1 sneljo1 closed this as completed Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants