Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support read-only guest login #959

Open
bonustrack opened this issue Nov 1, 2024 · 5 comments
Open

feat: support read-only guest login #959

bonustrack opened this issue Nov 1, 2024 · 5 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bonustrack
Copy link
Member

bonustrack commented Nov 1, 2024

We should support login with arbitrary address within our UI in read only. Instead of using WalletConnect and https://guest.so, we could made this feature available with simply an input in the log in modal. Ideally we should also have a route to login user directly like https://snapshot.box/login/0xeF8305E140ac520225DAf050e2f71d5fBcC543e7 that redirect to /#/home

You can use Ethers.js Provider to initiate an connexion with a custom address for read functions.

Duplicate: https://github.com/snapshot-labs/workflow/issues/225

@bonustrack bonustrack added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 1, 2024
@yehia67
Copy link

yehia67 commented Nov 2, 2024

Hi @bonustrack 👋
May I help on this?

@bonustrack
Copy link
Member Author

@yehia67 Sure go for it!

@yehia67
Copy link

yehia67 commented Nov 2, 2024

Thanks! on it 🏃‍♂️

@yehia67
Copy link

yehia67 commented Nov 3, 2024

@bonustrack may you please update the workflow link https://github.com/snapshot-labs/workflow/issues/225
It gave me 404,
But I guess I understand the flow

  1. A new input will be added to the login modal.
  2. User set any Ethereum address.
  3. Using Ethers.js I fetch some data from this profile and redirect the user to the read-only mode.
    Is that correct?

@bonustrack
Copy link
Member Author

@yehia67 There isn't more info available there: https://github.com/snapshot-labs/workflow/issues/225, if you need anything you can ask here.

For the flow that's correct, you'll need to propose a design that match with the app, reusing existing components as much as possible.

For the step 3, there is already logic to fetch data for a profile, you just need to connect a Web3Provider from Ethers.js as read only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants