From 4e22ebf6af0f38d63a59a9647032911e60b627fa Mon Sep 17 00:00:00 2001 From: Pedro Ramos Date: Wed, 31 Jan 2024 14:15:07 +0100 Subject: [PATCH] feat: rename one of the metrics (#12) * Rename the methods for one of the metrics * Upgrade '@smoya/asyncapi-adoption-metrics' to latest version --- package-lock.json | 8 ++++---- package.json | 2 +- src/base.ts | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/package-lock.json b/package-lock.json index ef2628b2310..03d8c1cb216 100644 --- a/package-lock.json +++ b/package-lock.json @@ -24,7 +24,7 @@ "@oclif/core": "^1.26.2", "@oclif/errors": "^1.3.6", "@oclif/plugin-not-found": "^2.3.22", - "@smoya/asyncapi-adoption-metrics": "^2.3.0", + "@smoya/asyncapi-adoption-metrics": "^2.4.0", "@smoya/multi-parser": "^4.0.0", "@stoplight/spectral-cli": "6.9.0", "ajv": "^8.12.0", @@ -4567,9 +4567,9 @@ } }, "node_modules/@smoya/asyncapi-adoption-metrics": { - "version": "2.3.0", - "resolved": "https://registry.npmjs.org/@smoya/asyncapi-adoption-metrics/-/asyncapi-adoption-metrics-2.3.0.tgz", - "integrity": "sha512-KrDT5hPVbR0n3LgwGKySr18Ux5bZ0oP4lZGwkvyCFZYkPmB6WCVqXHhpplHHEDSfWNK3l6ga4bBo0YyErGVgIQ==", + "version": "2.4.0", + "resolved": "https://registry.npmjs.org/@smoya/asyncapi-adoption-metrics/-/asyncapi-adoption-metrics-2.4.0.tgz", + "integrity": "sha512-/oJKdnWfKAJn/rZUttCSmZpQdf3V++QVqkXCmoxduTME0M8yphGpts0D4OTRiT+AuS4QEVDw8LJdw9537VLbbg==", "dependencies": { "@smoya/multi-parser": "^5.0.0" } diff --git a/package.json b/package.json index 04c6ccb25c5..dec658f677c 100644 --- a/package.json +++ b/package.json @@ -23,7 +23,7 @@ "@oclif/core": "^1.26.2", "@oclif/errors": "^1.3.6", "@oclif/plugin-not-found": "^2.3.22", - "@smoya/asyncapi-adoption-metrics": "^2.3.0", + "@smoya/asyncapi-adoption-metrics": "^2.4.0", "@smoya/multi-parser": "^4.0.0", "@stoplight/spectral-cli": "6.9.0", "ajv": "^8.12.0", diff --git a/src/base.ts b/src/base.ts index f1351621802..0f4ae841924 100644 --- a/src/base.ts +++ b/src/base.ts @@ -32,7 +32,7 @@ export default abstract class extends Command { } } - async recordActionExecuted(action: string, metadata: MetricMetadata = {}, rawDocument?: string) { + async recordActionFinished(action: string, metadata: MetricMetadata = {}, rawDocument?: string) { if (rawDocument !== undefined) { try { const {document} = await this.parser.parse(rawDocument); @@ -47,7 +47,7 @@ export default abstract class extends Command { } const callable = async function(recorder: Recorder) { - await recorder.recordActionExecuted(action, metadata); + await recorder.recordActionFinished(action, metadata); }; await this.recordActionMetric(callable); @@ -75,7 +75,7 @@ export default abstract class extends Command { async finally(error: Error | undefined): Promise { await super.finally(error); this.metricsMetadata['success'] = error === undefined; - await this.recordActionExecuted(this.id as string, this.metricsMetadata, this.specFile?.text()); + await this.recordActionFinished(this.id as string, this.metricsMetadata, this.specFile?.text()); } recorderFromEnv(prefix: string): Recorder {