Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GENERATORS=score doesn't seem to do anything useful anymore #9

Closed
bdach opened this issue May 23, 2024 · 0 comments · Fixed by #11
Closed

GENERATORS=score doesn't seem to do anything useful anymore #9

bdach opened this issue May 23, 2024 · 0 comments · Fixed by #11

Comments

@bdach
Copy link
Contributor

bdach commented May 23, 2024

I don't have a conclusive counterexample to prove this - my suspicion is at most an educated hunch backed up by source reading - but I'm somewhat sure that #4 neutered GENERATORS=score.

The act of importing legacy scores was what made GENERATORS=score useful at all, because the score import was where the score conversions were happening. If now the tables are populated purely based on scores dumps, then nothing runs the score conversion anymore, and thus GENERATORS=score will always produce an empty spreadsheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant