Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 'Update' event #10913

Open
andrebastosdias opened this issue Feb 16, 2025 · 2 comments
Open

Remove the 'Update' event #10913

andrebastosdias opened this issue Feb 16, 2025 · 2 comments

Comments

@andrebastosdias
Copy link
Contributor

While fixing mechanics and unskipping tests, I noticed a clear trend: the Update event was responsible for many bugs and could often be replaced with the AnySwitchIn, AnyAfterMove, and Residual events (and sometimes the Start event as well). Some examples include the White Herb, Eject Pack, and Leppa Berry. Additionally, many healing berry-related bugs were resolved by introducing a TakeDamage event, which activates after the user takes damage.

I would like to either completely remove the Update event or refactor it so that it is only triggered in the three cases mentioned above (AnySwitchIn, AnyAfterMove, and Residual). I believe this would improve event management overall.

@urkerab
Copy link
Contributor

urkerab commented Feb 16, 2025

What would the difference between your proposed TakeDamage event and the existing DamagingHit event be?

@andrebastosdias
Copy link
Contributor Author

andrebastosdias commented Feb 16, 2025

That's already implemented here #10902. TakeDamage is used for any kind of damage (except self-confusion). Also, TakeDamage runs after AfterHit, unlike DamagingHit, so a Berry can be knocked off before healing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants