Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor use of HttpBindingIndex to simplify codegen #442

Closed
jdisanti opened this issue Jun 1, 2021 · 2 comments
Closed

Refactor use of HttpBindingIndex to simplify codegen #442

jdisanti opened this issue Jun 1, 2021 · 2 comments
Assignees

Comments

@jdisanti
Copy link
Collaborator

jdisanti commented Jun 1, 2021

Several of the protocol code generators use the Smithy HttpBindingIndex class to determine which members belong to which parts of the HTTP request/response. The HttpBindingIndex only returns meaningful information if there are @http traits in the Smithy model, so it doesn't work for all of the protocols, but it would simplify the XML codegen if we could generalize this functionality over its uses in both AwsQuery and RestXml, and it may also simplify the JSON generators.

The idea is to create a generalized HttpBindingResolver that can use HttpBindingIndex if there are @http traits, or fall back to some default logic if there aren't.

@jdisanti
Copy link
Collaborator Author

jdisanti commented Jun 2, 2021

@jdisanti
Copy link
Collaborator Author

This was fixed by #530.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant