Avoid making FsBuilder aware of http-body version at interface level
#3101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
ysaito/do-not-make-fs-builder-http-body-version-aware
branch
from
6f910d9
to
66dc4b0
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
https://github.com/awslabs/smithy-rs into ysaito/do-not-make-fs-builder-http-body-version-aware
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
approved these changes
Oct 26, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
deleted the
ysaito/do-not-make-fs-builder-http-body-version-aware
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Follow up on #3088
Description
This PR reverts
ByteStream::read_with_body_0_4_from,ByteStream::from_path_body_0_4, andByteStream::from_file_body_0_4to the old names since from a customers' point of view,FsBuildershould not mention anything about anhttp-bodyversion at the API level.FsBuilderis currently an opt-in feature (withrt-tokioenabled) and we make it tied tohttp-body-0-4-xby requiringrt-tokioincluding a dependency onhttp-bodyversion 0.4.x.Testing
Relied on the existing tests in CI
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.