Update toSnakeCase to better handle plurals, version numbers, and other pathological cases
#3037
Conversation
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
changed the title
toSnakeCase to better handle plurals, version numbers, and other pathological cases
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
| private fun String.splitOnWordBoundaries(): List<String> { | ||
| val out = mutableListOf<String>() | ||
| // These are whole words but cased differently, e.g. `IPv4`, `MiB`, `GiB`, `TtL` | ||
| val completeWords = listOf("ipv4", "ipv6", "sigv4", "mib", "gib", "ttl") |
There was a problem hiding this comment.
nit: Will the algorithm work correctly if we add a word to the list that has a substring of it already in the list? For example, if "sigv4a" is added to the list?
There was a problem hiding this comment.
Should we add "kib" to be future proof?
There was a problem hiding this comment.
yeah should work (but sigv4a should probably work properly already because the issue is about when you get to the capital V)
| private fun String.splitOnWordBoundaries(): List<String> { | ||
| val out = mutableListOf<String>() | ||
| // These are whole words but cased differently, e.g. `IPv4`, `MiB`, `GiB`, `TtL` | ||
| val completeWords = listOf("ipv4", "ipv6", "sigv4", "mib", "gib", "ttl") |
There was a problem hiding this comment.
Should we add "kib" to be future proof?
This commit introduces a word splitting algorithm used for snake casing that has much better results than the current Smithy algorithm. Specifically, it has better behavior for acronyms ending in `s`, version numbers, and compound acronyms like `MiB` and `GiB`.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Motivation and Context
There are currently a lot of fields in the SDK that are clearly converted to snake-case wrong:
Description
Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.