Move aws_smithy_http::operation::error::BuildError into aws-smithy-types
#3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Yeah, that distinction is blurry to me. For things like |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
reviewed
Oct 6, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
This commit addresses #3032 (comment)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Oct 12, 2023
Co-authored-by: John DiSanti <jdisanti@amazon.com>
This commit addresses #3032 (comment)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
deleted the
ysaito/move-operation-build-error-to-smithy-types
branch
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
…3070) ## Motivation and Context Completes #3054 (a follow-up on #3032) ## Description #3032 moved `BuildError` from `aws_smithy_http::operation::error` to `aws_smithy_types::error::operation`. That PR also left "breadcrumbs", so that customers could still consume `BuldError` from `aws_smithy_http` after the move. This PR turns breadcrumbs into deprecation messages (via `#[deprecated(...)]`) and updates existing places that used to use moved types from `aws_smithy_http` to `aws_smithy_types`. ## Testing Relied on tests in CI. ## Checklist - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: Russell Cohen <rcoh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Takes care of the first part of #3054 (the remaining part is denoted as
TODO(runtimeCratesVersioningCleanup)and until that's done the issue will not be closed).Description
This PR moves from
aws-smithy-http::operation::error::{BuildError, SerializationError}toaws-smithy-types::error::operation::{BuildError, SerializationError}.Within the origin crate, we leave "breadcrumbs" (i.e. reexports) for existing customers of the items above so they are not broken by the move. The breadcrumps will be removed by the part two of the issue.
As part of the move,
aws_smithy_http::endpoint::EndpointPrefix::newnow returns itscrate::endpoint::error::InvalidEndpointErrorinstead ofcrate::operation::error::BuildErrorfor two reasons:BuildErroris now in a stable crate and for anInvalidUrivariant to be created, it needed to take ahttp::uri::InvalidUrifrom a unstable crate, which we cannot expose in public API.Testing
Relied on the tests in CI.
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.