Fix lack of the Sync auto trait on event stream outputs
#2496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
force-pushed
the
jdisanti-fix-event-stream-output-auto-traits
branch
from
5774477
to
739b479
Compare
jdisanti
force-pushed
the
jdisanti-fix-event-stream-output-auto-traits
branch
from
739b479
to
fa55033
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Mar 24, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
unexge
pushed a commit
that referenced
this pull request
Apr 24, 2023
rcoh
pushed a commit
that referenced
this pull request
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Noticed S3's
SelectObjectContentOutputdoesn't implementSyncwhile every other output type does. Looks like trait bounds on aBox<dyn>inside of the event streamReceiverwere to blame.Testing
Verified
SelectObjectContentOutputnow implementsSyncviacargo doc.Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.