Upgrade to Rust 1.62.0 #1825
Merged
Upgrade to Rust 1.62.0 #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeMathWalker
commented
Oct 7, 2022
Comment on lines
-28
to
+29
| pyo3 = "0.16.5" | ||
| pyo3-asyncio = { version = "0.16.0", features = ["tokio-runtime"] } | ||
| pyo3 = "0.17.0" | ||
| pyo3-asyncio = { version = "0.17.0", features = ["tokio-runtime"] } |
There was a problem hiding this comment.
This was necessary to fix a bunch of noisy reborrow lints - is upgrading an issue? Everything compiles and all tests are passing.
@crisidev @unexge
https://pyo3.rs/v0.17.0/migration.html#from-016-to-017
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jjant
reviewed
Oct 12, 2022
| @@ -41,7 +41,7 @@ pub enum OsFamily { | |||
| /// is set to a specific value. This macro simplifies checking the current OS family. | |||
| /// | |||
| /// Usage: | |||
| /// ```rust | |||
| /// ```ignore | |||
There was a problem hiding this comment.
See e68dfb7 for the reason on the ignore here.
rust is redundant and can be removed.
jdisanti
approved these changes
Oct 12, 2022
weihanglo
reviewed
Oct 12, 2022
|
@weihanglo Good idea, but I'll do it in a different PR. I'd rather not add a diff of ~50 |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Upgrade MSRV to Rust 1.62.0.
Description
We are upgrading the Rust version in our various configs and fixing all relevant Clippy lints.
In the process of upgrading Rust, we had to upgrade
pyo3andpyo3-asynciofrom0.16to0.17.Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.