Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code generator version number should be emitted in generated crate #1612

Closed
drganjoo opened this issue Aug 2, 2022 · 0 comments · Fixed by #1621
Closed

Code generator version number should be emitted in generated crate #1612

drganjoo opened this issue Aug 2, 2022 · 0 comments · Fixed by #1621
Assignees
Labels
good first issue Good for newcomers server Rust server SDK

Comments

@drganjoo
Copy link
Contributor

drganjoo commented Aug 2, 2022

Motivation and Context

Looking at the code that was generated by the "SmithyRs Code Generator" one cannot tell the version of the generator that was used.

Knowing the versions can help in post-deployment to track version specific bugs, and to potentially inform customers to regenerate in case of some vulnerability.

What is required

Cargo.toml has a metadata field that can be used to write additional information about the generator.

@drganjoo drganjoo added good first issue Good for newcomers server Rust server SDK labels Aug 2, 2022
@unexge unexge self-assigned this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers server Rust server SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants