From 13c04dafcf5d0f6d65a3edf54b78193f00b44265 Mon Sep 17 00:00:00 2001 From: John DiSanti Date: Fri, 19 Apr 2024 12:40:24 -0700 Subject: [PATCH] Revert cargo-semver-checks version due to performance regression (#3594) It seems upgrading cargo-semver-checks to 0.30 made it take significantly longer than before (going from less than 20 minutes up to between 1-4 hours). Reverting it back to 0.24.1 for now to keep CI faster. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --- .github/workflows/ci-pr.yml | 6 +++--- tools/ci-build/Dockerfile | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci-pr.yml b/.github/workflows/ci-pr.yml index 8cc490016d..31fc8fbf50 100644 --- a/.github/workflows/ci-pr.yml +++ b/.github/workflows/ci-pr.yml @@ -113,7 +113,7 @@ jobs: SMITHY_RS_PULL_REQUEST_CDN_ROLE_ARN: ${{ secrets.SMITHY_RS_PULL_REQUEST_CDN_ROLE_ARN }} semver-checks: - name: check the semver status of this PR + name: Check PR semver compliance runs-on: smithy_ubuntu-latest_8-core timeout-minutes: 20 needs: @@ -153,6 +153,6 @@ jobs: with: action: check-semver action-arguments: ${{ github.event.pull_request.base.sha }} ${{ fromJSON(steps.check-breaking-label.outputs.result).isBreaking }} - - name: print help message + - name: Print help message if: failure() - run: echo "::error::This pull request contains breaking changes. Please add the `breaking-changes` label and a changelog entry" + run: echo "::error::This pull request either contains breaking changes, or has cross-crate changes that may be backwards compatible, but that cargo-semver-checks cannot verify. Please scrutinize the change for backwards compatibility." diff --git a/tools/ci-build/Dockerfile b/tools/ci-build/Dockerfile index 44d2141a77..a383c06576 100644 --- a/tools/ci-build/Dockerfile +++ b/tools/ci-build/Dockerfile @@ -131,7 +131,7 @@ ARG rust_nightly_version RUN cargo +${rust_nightly_version} install cargo-component --locked --version ${cargo_component_version} FROM install_rust AS cargo_semver_checks -ARG cargo_semver_checks_version=0.30.0 +ARG cargo_semver_checks_version=0.24.1 RUN cargo install cargo-semver-checks --locked --version ${cargo_semver_checks_version} FROM install_rust AS cargo_mdbook