Some strings ('No input') in code are not internationalized (Validators too)

[idgserpro]

We're using 1.7.x, don't know if there are problems like this in 5 as well. We have:

https://github.com/smcmahon/Products.PloneFormGen/blob/1.7.23/Products/PloneFormGen/skins/PloneFormGen/fg_result_embedded_view.pt#L6

<dd tal:content="python:request.form.get(fname, 'No Input')" />

No input here should be internationalized. Which is the best way in this kind of context (a python code in a tal template?)

Some other files that we have this 'No input' references:

skins/PloneFormGen/fg_testresult_view.pt
content/fieldsBase.py
content/formLikertField.py
content/fields.py
content/thanksPage.py
content/formMailerAdapter.py

Is this 'No input' being used as a constant instead, since we have https://github.com/smcmahon/Products.PloneFormGen/blob/1.7.23/Products/PloneFormGen/content/thanksPage.py#L258?

if self.includeEmpties or (value and (value != 'No Input')): 

The validators have the same problem:

https://github.com/smcmahon/Products.PloneFormGen/blob/1.7.23/Products/PloneFormGen/validators/BooleanValidators.py#L28

https://github.com/smcmahon/Products.PloneFormGen/blob/1.7.23/Products/PloneFormGen/validators/CaptchaValidator.py#L27

https://github.com/smcmahon/Products.PloneFormGen/blob/1.7.23/Products/PloneFormGen/validators/ExRangeValidator.py#L46

https://github.com/smcmahon/Products.PloneFormGen/blob/1.7.23/Products/PloneFormGen/validators/MaxLengthValidator.py#L46

https://github.com/smcmahon/Products.PloneFormGen/blob/1.7.23/Products/PloneFormGen/validators/TextValidators.py#L40

[mauritsvanrees]

I have not tried it, but nstead of this:

<dd tal:content="python:request.form.get(fname, 'No Input')" />

probably this works:

<tal:block define="value python:request.form.get(fname, None)">
  <dd tal:condition="python:value is not None" tal:content="value" />
  <dd tal:condition="python:value is None" i18n:translate="">No Input</dd>
</tal:block>

I guess this dd from fg_result_embedded_view.pt does not end up in the request, so the check in the thanks page should be fine.

For the validators, maybe simply returning _(...) already works, which would be good. Otherwise you might need to explicitly call zope.i18n.translate on the error string before returning it.

Pull requests are welcome.