From 03d8e86f9cf1d9666df4eecf00a505a0116bc099 Mon Sep 17 00:00:00 2001 From: Matthew McAllister Date: Thu, 28 Nov 2024 19:10:38 -0500 Subject: [PATCH 1/4] DF-20817 update sensible rate limits for anchorage, bitgo, and coinbase-prime well under their max API limits --- packages/sources/anchorage/src/index.ts | 8 ++++++++ packages/sources/bitgo/src/index.ts | 8 ++++++++ packages/sources/coinbase-prime/src/index.ts | 2 +- 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/packages/sources/anchorage/src/index.ts b/packages/sources/anchorage/src/index.ts index d327a72ea3..5d10552180 100644 --- a/packages/sources/anchorage/src/index.ts +++ b/packages/sources/anchorage/src/index.ts @@ -8,6 +8,14 @@ export const adapter = new PoRAdapter({ name: 'ANCHORAGE', config, endpoints: [wallet], + rateLimiting: { + tiers: { + default: { + rateLimit1m: 30, + note: 'Docs: 10 requests per second per Organization, bursts of up to 100 requests per second', + }, + }, + }, }) export const server = (): Promise => expose(adapter) diff --git a/packages/sources/bitgo/src/index.ts b/packages/sources/bitgo/src/index.ts index 00fc384b7b..731b5c7d06 100644 --- a/packages/sources/bitgo/src/index.ts +++ b/packages/sources/bitgo/src/index.ts @@ -8,6 +8,14 @@ export const adapter = new PoRAdapter({ name: 'BITGO', config, endpoints: [wallet], + rateLimiting: { + tiers: { + default: { + rateLimit1m: 30, + note: 'Docs: 360 requests per minute per auth', + }, + }, + }, }) export const server = (): Promise => expose(adapter) diff --git a/packages/sources/coinbase-prime/src/index.ts b/packages/sources/coinbase-prime/src/index.ts index ca1d253617..79cadedf0c 100644 --- a/packages/sources/coinbase-prime/src/index.ts +++ b/packages/sources/coinbase-prime/src/index.ts @@ -11,7 +11,7 @@ export const adapter = new PoRAdapter({ rateLimiting: { tiers: { default: { - rateLimit1s: 25, + rateLimit1s: 5, note: 'Using the most restrictive rate limit. Docs: IP address at 100 requests per second (rps). Portfolio ID at 25 rps with a burst of 50 rps.', }, }, From dc31f85de893687e46e4d8f6e4f68118e8a8a34e Mon Sep 17 00:00:00 2001 From: Matthew McAllister Date: Thu, 28 Nov 2024 19:11:12 -0500 Subject: [PATCH 2/4] add changeset --- .changeset/witty-bananas-tease.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .changeset/witty-bananas-tease.md diff --git a/.changeset/witty-bananas-tease.md b/.changeset/witty-bananas-tease.md new file mode 100644 index 0000000000..8b847fe267 --- /dev/null +++ b/.changeset/witty-bananas-tease.md @@ -0,0 +1,7 @@ +--- +'@chainlink/coinbase-prime-adapter': patch +'@chainlink/anchorage-adapter': patch +'@chainlink/bitgo-adapter': patch +--- + +Update default rate limit From 9db48eaa49a786f8191e03a73c8bc5f366418fca Mon Sep 17 00:00:00 2001 From: Michael Xiao Date: Thu, 28 Nov 2024 21:37:08 -0500 Subject: [PATCH 3/4] Wait in-between soak test --- .github/workflows/soak-test-start.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/soak-test-start.yml b/.github/workflows/soak-test-start.yml index c4772fdcfd..e6f8b16590 100644 --- a/.github/workflows/soak-test-start.yml +++ b/.github/workflows/soak-test-start.yml @@ -198,6 +198,12 @@ jobs: done fi + - name: Wait 10 Minutes for adapters to deply + if: steps.get-pr-info.outputs.TEST_ADAPTERS != '' + uses: jakejarvis/wait-action@919fc193e07906705e5b7a50f90ea9e74d20b2b0 # v0.1.1 + with: + time: '10m' + - name: Deploy k6 if: steps.get-pr-info.outputs.TEST_ADAPTERS != '' env: From 22c51ddec5d763451528b15f2babbfe1bf07b619 Mon Sep 17 00:00:00 2001 From: Matthew McAllister Date: Fri, 29 Nov 2024 13:30:27 -0500 Subject: [PATCH 4/4] remove soak test update --- .github/workflows/soak-test-start.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/soak-test-start.yml b/.github/workflows/soak-test-start.yml index e6f8b16590..c4772fdcfd 100644 --- a/.github/workflows/soak-test-start.yml +++ b/.github/workflows/soak-test-start.yml @@ -198,12 +198,6 @@ jobs: done fi - - name: Wait 10 Minutes for adapters to deply - if: steps.get-pr-info.outputs.TEST_ADAPTERS != '' - uses: jakejarvis/wait-action@919fc193e07906705e5b7a50f90ea9e74d20b2b0 # v0.1.1 - with: - time: '10m' - - name: Deploy k6 if: steps.get-pr-info.outputs.TEST_ADAPTERS != '' env: