Skip to content

Commit 8a82cb2

Browse files
committed
Fix lint
1 parent ac89526 commit 8a82cb2

File tree

2 files changed

+18
-17
lines changed

2 files changed

+18
-17
lines changed

integration-tests/go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ require (
1313
github.com/google/uuid v1.6.0
1414
github.com/lib/pq v1.10.9
1515
github.com/pelletier/go-toml/v2 v2.2.2
16-
github.com/pkg/errors v0.9.1
1716
github.com/rs/zerolog v1.31.0
1817
github.com/smartcontractkit/chainlink-common v0.2.2-0.20240805160614-501c4f40b98c
1918
github.com/smartcontractkit/chainlink-solana v1.1.0
@@ -330,6 +329,7 @@ require (
330329
github.com/peterbourgon/diskv v2.0.1+incompatible // indirect
331330
github.com/petermattis/goid v0.0.0-20230317030725-371a4b8eda08 // indirect
332331
github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8 // indirect
332+
github.com/pkg/errors v0.9.1 // indirect
333333
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
334334
github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c // indirect
335335
github.com/prometheus/alertmanager v0.26.0 // indirect

integration-tests/testconfig/testconfig.go

+17-16
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import (
99
"strings"
1010
"time"
1111

12-
"github.com/pkg/errors"
12+
"errors"
1313

1414
"github.com/barkimedes/go-deepcopy"
1515
"github.com/google/uuid"
@@ -48,10 +48,11 @@ type TestConfig struct {
4848
}
4949

5050
const (
51-
E2E_TEST_COMMON_RPC_URL_ENV = "E2E_TEST_COMMON_RPC_URL"
52-
E2E_TEST_COMMON_WS_URL_ENV = "E2E_TEST_COMMON_WS_URL"
53-
E2E_TEST_COMMON_PRIVATE_KEY_ENV = "E2E_TEST_COMMON_PRIVATE_KEY" // Private key in byte format [12, 12 ...]
54-
E2E_TEST_SOLANA_SECRET = "E2E_TEST_SOLANA_SECRET"
51+
E2E_TEST_COMMON_RPC_URL_ENV = "E2E_TEST_COMMON_RPC_URL" // revive:disable-line:var-naming
52+
E2E_TEST_COMMON_WS_URL_ENV = "E2E_TEST_COMMON_WS_URL" // revive:disable-line:var-naming
53+
// Private key in byte format [12, 12 ...]
54+
E2E_TEST_COMMON_PRIVATE_KEY_ENV = "E2E_TEST_COMMON_PRIVATE_KEY" // revive:disable-line:var-naming
55+
E2E_TEST_SOLANA_SECRET = "E2E_TEST_SOLANA_SECRET" // revive:disable-line:var-naming
5556
)
5657

5758
// Read config values from environment variables
@@ -106,28 +107,28 @@ func (c *TestConfig) ReadFromEnvVar() error {
106107
c.Logging.Loki.BearerToken = &lokiBearerToken
107108
}
108109

109-
grafanaBaseUrl := ctf_config.MustReadEnvVar_String(ctf_config.E2E_TEST_GRAFANA_BASE_URL_ENV)
110-
if grafanaBaseUrl != "" {
110+
grafanaBaseURL := ctf_config.MustReadEnvVar_String(ctf_config.E2E_TEST_GRAFANA_BASE_URL_ENV)
111+
if grafanaBaseURL != "" {
111112
if c.Logging == nil {
112113
c.Logging = &ctf_config.LoggingConfig{}
113114
}
114115
if c.Logging.Grafana == nil {
115116
c.Logging.Grafana = &ctf_config.GrafanaConfig{}
116117
}
117118
logger.Info().Msgf("Using %s env var to override Logging.Grafana.BaseUrl", ctf_config.E2E_TEST_GRAFANA_BASE_URL_ENV)
118-
c.Logging.Grafana.BaseUrl = &grafanaBaseUrl
119+
c.Logging.Grafana.BaseUrl = &grafanaBaseURL
119120
}
120121

121-
grafanaDashboardUrl := ctf_config.MustReadEnvVar_String(ctf_config.E2E_TEST_GRAFANA_DASHBOARD_URL_ENV)
122-
if grafanaDashboardUrl != "" {
122+
grafanaDashboardURL := ctf_config.MustReadEnvVar_String(ctf_config.E2E_TEST_GRAFANA_DASHBOARD_URL_ENV)
123+
if grafanaDashboardURL != "" {
123124
if c.Logging == nil {
124125
c.Logging = &ctf_config.LoggingConfig{}
125126
}
126127
if c.Logging.Grafana == nil {
127128
c.Logging.Grafana = &ctf_config.GrafanaConfig{}
128129
}
129130
logger.Info().Msgf("Using %s env var to override Logging.Grafana.DashboardUrl", ctf_config.E2E_TEST_GRAFANA_DASHBOARD_URL_ENV)
130-
c.Logging.Grafana.DashboardUrl = &grafanaDashboardUrl
131+
c.Logging.Grafana.DashboardUrl = &grafanaDashboardURL
131132
}
132133

133134
grafanaBearerToken := ctf_config.MustReadEnvVar_String(ctf_config.E2E_TEST_GRAFANA_BEARER_TOKEN_ENV)
@@ -169,13 +170,13 @@ func (c *TestConfig) ReadFromEnvVar() error {
169170
c.Network.WalletKeys = walletKeys
170171
}
171172

172-
rpcHttpUrls := ctf_config.ReadEnvVarGroupedMap(ctf_config.E2E_TEST_RPC_HTTP_URL_ENV, ctf_config.E2E_TEST_RPC_HTTP_URLS_ENV)
173-
if len(rpcHttpUrls) > 0 {
173+
rpcHTTPUrls := ctf_config.ReadEnvVarGroupedMap(ctf_config.E2E_TEST_RPC_HTTP_URL_ENV, ctf_config.E2E_TEST_RPC_HTTP_URLS_ENV)
174+
if len(rpcHTTPUrls) > 0 {
174175
if c.Network == nil {
175176
c.Network = &ctf_config.NetworkConfig{}
176177
}
177178
logger.Info().Msgf("Using %s and/or %s env vars to override Network.RpcHttpUrls", ctf_config.E2E_TEST_RPC_HTTP_URL_ENV, ctf_config.E2E_TEST_RPC_HTTP_URLS_ENV)
178-
c.Network.RpcHttpUrls = rpcHttpUrls
179+
c.Network.RpcHttpUrls = rpcHTTPUrls
179180
}
180181

181182
rpcWsUrls := ctf_config.ReadEnvVarGroupedMap(ctf_config.E2E_TEST_RPC_WS_URL_ENV, ctf_config.E2E_TEST_RPC_WS_URLS_ENV)
@@ -561,13 +562,13 @@ func GetConfig(configurationName string, product Product) (TestConfig, error) {
561562
logger.Info().Msg("Loading config values from default ~/.testsecrets env file")
562563
err = ctf_config.LoadSecretEnvsFromFiles()
563564
if err != nil {
564-
return TestConfig{}, errors.Wrapf(err, "error reading test config values from ~/.testsecrets file")
565+
return TestConfig{}, fmt.Errorf("error reading test config values from ~/.testsecrets file: %w", err)
565566
}
566567

567568
logger.Info().Msg("Reading values from environment variables")
568569
err = testConfig.ReadFromEnvVar()
569570
if err != nil {
570-
return TestConfig{}, errors.Wrapf(err, "error reading test config values from env vars")
571+
return TestConfig{}, fmt.Errorf("error reading test config values from env vars: %w", err)
571572
}
572573

573574
logger.Debug().Msg("Validating test config")

0 commit comments

Comments
 (0)