Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ack related docs issues #2733

Closed
pawel-boguski-ds opened this issue Aug 20, 2024 · 0 comments
Closed

Ack related docs issues #2733

pawel-boguski-ds opened this issue Aug 20, 2024 · 0 comments
Labels

Comments

@pawel-boguski-ds
Copy link

According to the doc it is possible to use post-processing ack while receiving a single payload and producing a stream of payloads: https://smallrye.io/smallrye-reactive-messaging/4.24.0/concepts/acknowledgement/#acknowledgment-when-using-streams

For method receiving a single payload and producing a stream of payloads, it defaults to pre-processing acknowledgement. However, in this case, post-processing is supported. It waits for all the produced messages to be acknowledged before acknowledging the received one. If one of the produced message is nacked, the received one is nacked immediately.

But in methods signatures page the post processing is not listed:
https://smallrye.io/smallrye-reactive-messaging/4.24.0/concepts/signatures/#method-signatures-to-process-data

@Outgoing @incoming Multi method(I payload) PRE_PROCESSING, NONE

The post-processing ack works for this signature however there is an issue with nack (I created separated issue here #2732)

Other issue in the method signatures is: ‘Called once at assembly time’ which is not true as the method is actually ‘Called for every incoming message’.

ozangunalp added a commit to ozangunalp/smallrye-reactive-messaging that referenced this issue Aug 29, 2024
ozangunalp added a commit to ozangunalp/smallrye-reactive-messaging that referenced this issue Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants