Skip to content

Commit ec023b9

Browse files
committed
Update error logging in Upvs::SubmitMessageDraftJob
1 parent 8fbf499 commit ec023b9

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

app/jobs/govbox/submit_message_draft_job.rb

+8-4
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def perform(message_draft, bulk_submit: false, upvs_client: UpvsEnvironment.upvs
5757
message_draft.submitted!
5858
Govbox::SyncBoxJob.set(wait: 3.minutes).perform_later(box) unless bulk_submit
5959
else
60-
handle_submit_fail(message_draft, response_status, response_body.dig("message"))
60+
handle_submit_fail(message_draft, response_status, response_body)
6161
end
6262
end
6363

@@ -81,7 +81,7 @@ def build_objects(message_draft)
8181
objects
8282
end
8383

84-
def handle_submit_fail(message_draft, response_status, response_message)
84+
def handle_submit_fail(message_draft, response_status, response_body)
8585
# TODO notification
8686
message_draft.add_cascading_tag(message_draft.tenant.submission_error_tag)
8787

@@ -90,12 +90,16 @@ def handle_submit_fail(message_draft, response_status, response_message)
9090
message_draft.metadata["status"] = "temporary_submit_fail"
9191
message_draft.save
9292

93-
raise TemporarySubmissionError, "Message #{message_draft.uuid}: #{response_status}, #{response_message}"
93+
raise TemporarySubmissionError, error_message(message_draft, response_status, response_body)
9494
else
9595
message_draft.metadata["status"] = "submit_fail"
9696
message_draft.save
9797

98-
raise SubmissionError, "Message #{message_draft.uuid}: #{response_status}, #{response_message}"
98+
raise SubmissionError, error_message(message_draft, response_status, response_body)
9999
end
100100
end
101+
102+
def error_message(message_draft, response_status, response_body)
103+
"Box #{message_draft.box.id}, Message #{message_draft.uuid}: #{response_status}, #{response_body}"
104+
end
101105
end

0 commit comments

Comments
 (0)