Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deps available in all environments #26

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

thiamsantos
Copy link
Contributor

Motivations

We are getting compilation errors after typeid was added to our project.

Proposed solution

The error seems to be caused by if Code.ensure_loaded?(Ecto.ParameterizedType) do

Not always the dep is available to typeid in compilation.

If we continue to mark it as optional, but allow in all environments we can compile without warnings.

@sloanelybutsurely sloanelybutsurely self-requested a review October 6, 2023 20:09
@sloanelybutsurely
Copy link
Owner

@thiamsantos thanks for this!

@sloanelybutsurely sloanelybutsurely merged commit b917263 into sloanelybutsurely:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants