Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing IE conditionals (/[if IE]) #127

Closed
little-bobby-tables opened this issue May 20, 2017 · 3 comments
Closed

Consider removing IE conditionals (/[if IE]) #127

little-bobby-tables opened this issue May 20, 2017 · 3 comments

Comments

@little-bobby-tables
Copy link
Contributor

Support for conditional comments was removed in IE10, which itself has reached the end of life more than a year ago.

That's not the main reason I'm bringing this up, however. The problem is in the way it's currently implemented in Slime: the content of the conditional is not parsed (like it should be), rather, it is treated as plain text. This defeats the purpose of <!--[if IE]>, which is to inject browser-specific DOM elements.

Fixing the behavior will increase the complexity of the parser — why not just remove it? In case it's absolutely necessary, the conditionals can be inserted as ordinary HTML tags anyway:

<!--[if IE 9]>
    p Get a better browser
<![endif]-->
@Rakoth
Copy link
Member

Rakoth commented May 20, 2017

+1 to drop support

@doomspork
Copy link
Member

Let's remove it!

@Rakoth
Copy link
Member

Rakoth commented Jun 13, 2017

closed by #128

@Rakoth Rakoth closed this as completed Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants