-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't compile on latest nightly #37
Comments
+1 |
Sorry guys, was busy with other stuff for a bit. Just noticed the automated tests were failing. I'm going to attempt to find a workaround for this, as it seems probably not okay for me to just entirely remove all of the combination helpers for some unspecified amount of time considering they've been implemented in their current form and working perfectly for months at this point. For the record I don't think I necessarily agree with this now being a compiler "error" in general, also. It's essentially saying, "simple compile-time addition of two must-be-known-at-compile-time-anyways usizes may fail", which while I guess is technically a possibility in theory would still indeed be caught at compile time and as such is not something that could lead to any kind of un-Rusty hard-to-notice runtime bugs. I don't see who exactly in what exact scenario that PR is supposed to benefit. |
I'm not a rust contributor or anything, IIUC, this will be fixed somehow before the feature is stabilized, by allowing to specify bounds on const generics. Honestly, as a user of this library, I would rather get a "combinator"-less version of |
Oh yeah, I for sure want to get it working ASAP. Like, today ASAP. I'm just legitimately not sure what the "appropriate" thing to do here is if I cannot find a workaround. For example, I could easily just remove the combination helper stuff entirely for now and release a 0.9.4 version of the crate without them, but that (I think) would be breaking the standard Rust versioning practices that people expect. Maybe they'd be okay with it in this scenario, though. Or maybe not. It's hard to gauge. Any advice or input would be welcome! |
I do think it warrants a minor-version bump (0.10.0, I guess). That would also mean that any downstream crates would have to release a new version themselves with the updated dependency on That's just my own $0.02, I definitely am not an expert on any of the things I talked about, so take with grain of salt etc... :P |
0.10.0 it is then I think. Will try to get it uploaded soon. |
Argh, now I have to find something different that looks cool to put in the readme also... this is the most annoying thing ever. No choice though... |
I've put 0.10.0 up on crates.io now. Let me know if it fixes everything for your use case! |
Hey, I'm sorry for not being explicit enough sooner: |
No problem! |
This PR broke the current functionality: rust-lang/rust#70107
Starting with the June 3rd nightly,
staticvec
fails to build.IIUC, this is not a compiler bug, but rather a feature.
I think that until const bounds are implemented, there is no way to implement
concat
and all the other "combination" helpers.The text was updated successfully, but these errors were encountered: