Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt 1.1 / manifest v5 support ? #31

Closed
aa-matthias opened this issue Jun 18, 2022 · 5 comments
Closed

dbt 1.1 / manifest v5 support ? #31

aa-matthias opened this issue Jun 18, 2022 · 5 comments

Comments

@aa-matthias
Copy link

aa-matthias commented Jun 18, 2022

Hi,

are you going to add support for manifest v5 as well? It's currently outputting a warning aying manifest v5 is not supported.

Thanks a lot!

@mrshu
Copy link
Contributor

mrshu commented Jun 21, 2022

Hi @aa-matthias, this is indeed something we'll look at supporting in the future 🙂

@reegs
Copy link

reegs commented Jul 24, 2022

@mrshu Based on the dbt version changelogs and the issues included in 1.1 related to the manifest 1 and 2, but in particular the first one I linked, it seems like dbt-core is treating version 5 of the manifest as compatible with version 4 so it shouldn't require any changes in parsing logic, just adding that versions 4 and 5 of the manifest can be treated the same by dbt-coverage

@mrshu
Copy link
Contributor

mrshu commented Jul 25, 2022

Cool, thanks @reegs!

@sweco what do you say? Would it make sense to support the version 5 of the manifest as well?

@sweco
Copy link
Collaborator

sweco commented Jul 25, 2022

Hey all, thank you all for analyzing the changes in the manifest. 😊 I'm marking manifest v5 to the list of the supported versions in #34.

@sweco
Copy link
Collaborator

sweco commented Jul 25, 2022

Released in https://github.com/slidoapp/dbt-coverage/releases/tag/v0.2.1. Thank you for reporting the issue and thus helping with the development of the project! 😊

@sweco sweco closed this as completed Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants