Allow accessing fetched entities of a Storage
#515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnneKitsune
suggested changes
Nov 22, 2018
|
I don't think it's worth it to hide this without demonstrated evidence it confuses people. I think we should leave it visible until we get a lot of confused users. |
AnneKitsune
approved these changes
Nov 22, 2018
|
Hmm, I thought you're going to say something like this ^^ That's why I hid it. If you insist on this, the only option I see is to give it a longer name to make sure this is obvious. |
|
I'd definitely be in favor of the longer name option. The way it is currently would still come up in editor auto completes but there would be no documentation. That's even more confusing. |
|
Done. |
bors bot
added a commit
that referenced
this pull request
Nov 22, 2018
515: Allow accessing fetched entities of a `Storage` r=Xaeroxe a=torkleyy I've added `Storage::entities` to allow making extension methods for `Storage` that return `Entity`. This method is hidden because I'm 100% certain newcomers will be confused by this otherwise. This makes it less visible, yes, but I think that's worth for avoiding this confusion. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/slide-rs/specs/515) <!-- Reviewable:end --> Co-authored-by: Thomas Schaller <torkleyy@gmail.com>
AnneKitsune
approved these changes
Nov 22, 2018
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added
Storage::entitiesto allow making extension methods forStoragethat returnEntity.This method is hidden because I'm 100% certain newcomers will be confused by this otherwise. This makes it less visible, yes, but I think that's worth for avoiding this confusion.
This change is