Make it possible to disable parallel feature #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkleyy
reviewed
Oct 18, 2018
Does wasm support threading at all? |
|
Well, not "enough" yet. There are some experimental things supported only
in Chrome I believe, but for the most part it's currently unsupported.
On Oct 18, 2018 16:07, "Zakarum" <notifications@github.com> wrote:
threading support in wasm
Does wasm support threading at all?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#495 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AWFFuYlelDxVwUT7T4IOy86lb9BFLvCDks5umIsMgaJpZM4XtdOv>
.
|
bors bot
added a commit
that referenced
this pull request
Oct 18, 2018
495: Make it possible to disable parallel feature r=Xaeroxe a=omni-viral This makes it possible to user specs in wasm environment <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/slide-rs/specs/495) <!-- Reviewable:end --> Co-authored-by: Zakarum <scareaangel@gmail.com>
|
Oh just re-read @torkleyy 's comment my bad bors r- |
Canceled |
|
Without making code super-inconsistent I managed to reduce amount of |
Rhuagh
approved these changes
Oct 18, 2018
|
Go ahead and r+ if you're happy with it @torkleyy |
torkleyy
approved these changes
Oct 18, 2018
|
Wow. *should we care about |
|
I confirm it works with wasm now |
Minor since new feature is first default feature.
|
I can confirm this works. I tried out @omni-viral's branch with the same code that wasn't working before this PR and now it works. |
|
Great, thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 19, 2018
495: Make it possible to disable parallel feature r=torkleyy a=omni-viral This makes it possible to user specs in wasm environment <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/slide-rs/specs/495) <!-- Reviewable:end --> Co-authored-by: Zakarum <scareaangel@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to user specs in wasm environment
This change is