Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document aliasing rules for resources #322

Merged
merged 1 commit into from
Dec 25, 2017
Merged

Document aliasing rules for resources #322

merged 1 commit into from
Dec 25, 2017

Conversation

torkleyy
Copy link
Member

@torkleyy torkleyy commented Dec 25, 2017 •
edited
Loading

Fixes #314

This change is Reviewable

@torkleyy
Copy link
Member Author

r? @Xaeroxe

Xaeroxe
Xaeroxe approved these changes Dec 25, 2017
View reviewed changes
Copy link
Member

@Xaeroxe Xaeroxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@torkleyy
Copy link
Member Author

Thanks for the review!

bors r+

bors bot added a commit that referenced this pull request Dec 25, 2017
@bors
Merge #322
7d2ec0a 
322: Document aliasing rules for resources r=torkleyy a=torkleyy

Fixes #314

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/slide-rs/specs/322)
<!-- Reviewable:end -->
@bors
Copy link
Contributor

bors bot commented Dec 25, 2017

Build succeeded

@bors bors bot merged commit a18f62d into amethyst:master Dec 25, 2017
@torkleyy torkleyy deleted the alias branch December 25, 2017 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xaeroxe Xaeroxe Xaeroxe approved these changes

Assignees
No one assigned
Labels
docs ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torkleyy @Xaeroxe