Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small adjustments in the documentation #278

Merged
merged 3 commits into from
Oct 2, 2017
Merged

small adjustments in the documentation #278

merged 3 commits into from
Oct 2, 2017

Conversation

hartmut
Copy link
Contributor

@hartmut hartmut commented Oct 1, 2017

minor changes in the specs book

Copy link
Member

@torkleyy torkleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, just two questions.

@@ -52,16 +52,16 @@ fairly well.

## `DenseVecStorage`

This storage uses two `Vec`s, one containing the actual data and the other
This storage uses two `Vec`\`s, one containing the actual data and the other
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a native speaker, but this change seems odd to me.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this was fine before the change

@@ -44,6 +44,8 @@ method call can be exchanged for `par_join`:
}
```

The `par_join` method produces a type implementing `rayon`s `ParallelIterator`
The `par_join` method produces a type implementing [`rayon`\`s `ParallelIterator`][ra]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't you use ' instead of ` here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, I am not a natural speaker too, so sorry for the misspelling

@torkleyy
Copy link
Member

torkleyy commented Oct 2, 2017

Thank you!

bors r+

bors bot added a commit that referenced this pull request Oct 2, 2017
278: small adjustments in the documentation r=torkleyy a=hartmut

minor changes in the specs book
@bors
Copy link
Contributor

bors bot commented Oct 2, 2017

Timed out

@torkleyy
Copy link
Member

torkleyy commented Oct 2, 2017

Seriously?

bors r+

bors bot added a commit that referenced this pull request Oct 2, 2017
278: small adjustments in the documentation r=torkleyy a=hartmut

minor changes in the specs book
@bors
Copy link
Contributor

bors bot commented Oct 2, 2017

Build succeeded

@bors bors bot merged commit 3213160 into amethyst:master Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants