-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add drain
method to Storage
#273
Conversation
I'm not sure why coverage goes down.. does it really want me to test |
You should be able to make coveralls to show the file and which lines are covered by test. |
The problem is that the coverage is inaccurate. E.g. I had to test derived traits, but that doesn't make any sense. I ran the coverage locally and it was not obvious what test I should add, see Gitter. |
Looks good to me. I tried it out with a few reduced test cases and it does exactly what I was asking for. Thanks @torkleyy! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is pretty cool!
ready to merge?
bors r+ |
Build succeeded |
Fixes #264