Change component definitions to use Self and destruct system data tuple in parameter list. #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, looks great! |
bors bot
added a commit
that referenced
this pull request
Jun 26, 2017
206: Change component definitions to use Self and destruct system data tuple in parameter list. r=kvark
This PR changes component definitions from:
````rust
impl Component for MyTotallyRadComponent {
type Storage = VecStorage<MyTotallyRadComponent>;
}
````
to
````rust
impl Component for MyTotallyRadComponent {
type Storage = VecStorage<Self>;
}
````
which is shorter for long types and easier to rename. Benefits are especially great when the type has to be repeated multiple times (eg. `FlaggedStorage<MyTotallyRadComponent, VecStorage<MyTotallyRadComponent>>` vs `FlaggedStorage<Self, VecStorage<Self>>`)
It also moves system data destructuring for tuples:
````rust
fn run(&mut self, data: Self::SystemData) {
let (first_component, mut second_component) = data;
````
to
````rust
fn run(&mut self, (first_component, mut second_component): Self::SystemData) {
````
which is shorter and conveys the fact that these component storages are takes as parameter (same way as tuple desugaring takes parameters).
NOTE: Removal of spaces at end of lines was done automatically by editor
Build succeeded |
xMAC94x
pushed a commit
to xMAC94x/specs
that referenced
this pull request
Mar 10, 2021
206: Update crate versions to `0.11.0` and `0.6.3`. r=azriel91 a=azriel91 Release changes for `0.11.0`. Co-authored-by: Azriel Hoh <azriel91@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes component definitions from:
to
which is shorter for long types and easier to rename. Benefits are especially great when the type has to be repeated multiple times (eg.
FlaggedStorage<MyTotallyRadComponent, VecStorage<MyTotallyRadComponent>>vsFlaggedStorage<Self, VecStorage<Self>>)It also moves system data destructuring for tuples:
to
which is shorter and conveys the fact that these component storages are takes as parameter (same way as tuple desugaring takes parameters).
NOTE: Removal of spaces at end of lines was done automatically by editor