Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure when compiled with MSVC #3

Open
Code7R opened this issue Nov 26, 2024 · 1 comment
Open

Test failure when compiled with MSVC #3

Code7R opened this issue Nov 26, 2024 · 1 comment

Comments

@Code7R
Copy link

Code7R commented Nov 26, 2024

Just what the title says. First one has to patch the Makefile a bit to use MSVC compiler (eventually I have created a CMakeLists.txt to make it compile).

And even if it compiles, we end up in execution errors:


   [KAT] (0) SLH-DSA-SHAKE-128s-1.rsp

   [KAT] (0) SLH-DSA-SHAKE-128f-1.rsp

   [KAT] (0) SLH-DSA-SHAKE-192s-1.rsp

   [KAT] (0) SLH-DSA-SHAKE-192f-1.rsp

   [KAT] (0) SLH-DSA-SHAKE-256s-1.rsp

   [KAT] (0) SLH-DSA-SHAKE-256f-1.rsp

   [KAT] (0) SLH-DSA-SHA2-128s-1.rsp

   [FAIL] slh_verify() fails.

   [KAT] (0) SLH-DSA-SHA2-128f-1.rsp

   [FAIL] slh_verify() fails.

   [KAT] (0) SLH-DSA-SHA2-192s-1.rsp

   [FAIL] slh_verify() fails.

   [KAT] (0) SLH-DSA-SHA2-192f-1.rsp

   [FAIL] slh_verify() fails.

   [KAT] (0) SLH-DSA-SHA2-256s-1.rsp

   [FAIL] slh_verify() fails.

   [KAT] (0) SLH-DSA-SHA2-256f-1.rsp

   [FAIL] slh_verify() fails.

   [INFO] test_slh_dsa() fail= 6

Current workaround: using clang compiler (i.e. LLVM). with that everything works. I have a feeling that something internally might be messed up with the datatype sizes, because MSVC and clang/GCC have a different idea of how big a LONG value (on x64) should be.

@mjosaarinen
Copy link
Contributor

I do not have access to MSVC so that I could address this issue. Yes, I'd also suspect differences in data type sizes and signedness, even though I tried to use stdint.h types consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants